JingsongLi commented on a change in pull request #8035: 
[FLINK-11975][table-planner-blink] Support to run a sql query : 'SELECT * FROM 
(VALUES (1, 2, 3)) T(a, b, c)'
URL: https://github.com/apache/flink/pull/8035#discussion_r268472470
 
 

 ##########
 File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/type/TypeConverters.java
 ##########
 @@ -238,4 +238,9 @@ public static TypeInformation 
createExternalTypeInfoFromInternalType(InternalTyp
                        throw new UnsupportedOperationException("Not support 
yet: " + type);
                }
        }
+
+       public static BaseRowTypeInfo toBaseRowTypeInfo(RowType t) {
 
 Review comment:
   This util is a bit redundant. Direct new BaseRowTypeInfo(t.getFieldTypes(), 
t.getFieldNames())?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to