beyond1920 commented on a change in pull request #8035:
[FLINK-11975][table-planner-blink] Support to run a sql query : 'SELECT * FROM
(VALUES (1, 2, 3)) T(a, b, c)'
URL: https://github.com/apache/flink/pull/8035#discussion_r268508925
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -79,6 +85,67 @@ class BatchTableEnvironment(
}
}
+ /**
+ * Merge global job parameters and table config parameters,
+ * and set the merged result to GlobalJobParameters
+ */
+ private def mergeParameters(): Unit = {
+ if (streamEnv != null && streamEnv.getConfig != null) {
+ val parameters = new Configuration()
+ if (config != null && config.getConf != null) {
+ parameters.addAll(config.getConf)
+ }
+
+ if (streamEnv.getConfig.getGlobalJobParameters != null) {
+ streamEnv.getConfig.getGlobalJobParameters.toMap.foreach {
+ kv => parameters.setString(kv._1, kv._2)
+ }
+ }
+
+ streamEnv.getConfig.setGlobalJobParameters(parameters)
+ }
+ }
+
+ /**
+ * Writes a [[Table]] to a [[TableSink]].
+ *
+ * Internally, the [[Table]] is translated into a [[DataStream]] and handed
over to the
+ * [[TableSink]] to write it.
+ *
+ * @param table The [[Table]] to write.
+ * @param sink The [[TableSink]] to write the [[Table]] to.
+ * @tparam T The expected type of the [[DataStream]] which represents the
[[Table]].
+ */
+ override private[table] def writeToSink[T](
+ table: Table,
+ sink: TableSink[T],
+ sinkName: String): Unit = {
+ mergeParameters()
+
+ val sinkNode =
LogicalSink.create(table.asInstanceOf[TableImpl].getRelNode, sink, sinkName)
+ val optimizedPlan = optimize(sinkNode)
+ val optimizedNodes = translateNodeDag(Seq(optimizedPlan))
+ translateNodeDag(Seq(optimizedPlan))
+ require(optimizedNodes.size() == 1)
+ translate(optimizedNodes.head)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
