TisonKun opened a new pull request #8046: [FLINK-12006][coordination] Ensure owned znode deleted on ZooKeeperHaServices#deleteOwnedZNode URL: https://github.com/apache/flink/pull/8046 ## What is the purpose of the change Since the failing log doesn't show an exception thrown, the case should be we passed ```java client.delete().deletingChildrenIfNeeded().forPath("/"); zNodeDeleted = true; ``` but the znode "/" wasn't be deleted. For any reason we use `client.checkExists().forPath("/")` to ensure its deletion. Also add `#guaranteed` on `#deleted` to best effort delete the znode even if we failed by an retryable exception. ## Verifying this change This change is already covered by existing tests, such as ZooKeeperHaServiceTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers:(no) - The runtime per-record code paths (performance sensitive):(no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) cc @tillrohrmann @GJL @aljoscha
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
