becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-476165215 @Xeli @rmetzger My apologies for being late on the review. I'll finish reviewing the testing part in one day or two. BTW, some previous comments might need to be addressed or further discussed. e.g. the thread-safe issue in `close()` and `stop()`. And the usage of `MultipleIdsMessageAcknowledgingSourceBase`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
