azagrebin commented on issue #7675: [FLINK-8297] [flink-rocksdb] A plan store elements of ListState as multiple key-values in rocksdb URL: https://github.com/apache/flink/pull/7675#issuecomment-477099950 Thanks for suggesting another approach @FaxianZhao ! This change looks quite involving. Usually, it is easier to discuss the design in Dev mailing list or Jira issue to get community's feedback firstly. In this case I am wondering if it is even maybe better to create a design document with the proposal and post it in Dev mailing list. This simplifies reaching a consensus about wether the suggested approach should be merged and getting confirmation from a committer who would be ready to merge it eventually. Especially, I think we might want to firstly discuss the reliability of timestamps for indexing elements order because of possible time shifts of machines which can change e.g. after restore to another machine. The design document could contain more details which would simplify understanding of the approach and the subsequent review of PR and merging. Could you create a design doc, post it in Dev mailing list/Jira issue and close this PR at the moment? Once, the design doc gets positive community feedback you can reopen this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
