zentol commented on a change in pull request #8060: [FLINK-12021] Deploy
execution in topological sorted order
URL: https://github.com/apache/flink/pull/8060#discussion_r269570466
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
##########
@@ -598,8 +593,11 @@ private void handleCompletedFuture(T value, Throwable
throwable) {
complete(Collections.emptyList());
}
else {
+ int counter = 0;
for (CompletableFuture<? extends T> future :
resultFutures) {
Review comment:
Isn't it common to only accept a `List` if the order of elements is relevant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
