tillrohrmann commented on a change in pull request #8060: [FLINK-12021] Deploy 
execution in topological sorted order
URL: https://github.com/apache/flink/pull/8060#discussion_r269651472
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
 ##########
 @@ -598,8 +593,11 @@ private void handleCompletedFuture(T value, Throwable 
throwable) {
                                complete(Collections.emptyList());
                        }
                        else {
+                               int counter = 0;
                                for (CompletableFuture<? extends T> future : 
resultFutures) {
 
 Review comment:
   I would not restrict the user on the type of collection he wants to use. The 
contract is that the result collection will have the same order as the input 
collection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to