KurtYoung commented on a change in pull request #8056:
[FLINK-12013][table-planner-blink] Support calc and correlate in blink
URL: https://github.com/apache/flink/pull/8056#discussion_r269845314
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
##########
@@ -250,4 +273,108 @@ class BatchTableEnvironment(
}
}
+ /**
+ * Registers the given [[Iterable]] as table in the
+ * [[TableEnvironment]]'s catalog.
+ *
+ * @param tableName name of table.
+ * @param data The [[Iterable]] to be converted.
+ * @param typeInfo information of [[Iterable]].
+ * @param fieldNames field names expressions, eg: 'a, 'b, 'c
+ * @tparam T The type of the [[Iterable]].
+ * @return The converted [[Table]].
+ */
+ def registerCollection[T](tableName: String, data: Iterable[T], typeInfo:
TypeInformation[T],
Review comment:
Can we move all "registerCollection"s to test as some utilities? We still
should make the differences between Flink and Blink's table env as small as
possible, to save future refactoring cost. I think we only need to expose
registerDataStream (bounded) for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
