zentol commented on a change in pull request #7807: [FLINK-11723][network]
Remove KvState related components from Network…
URL: https://github.com/apache/flink/pull/7807#discussion_r270034319
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -748,13 +752,15 @@ public void updateTaskExecutionState(TaskExecutionState
taskExecutionState) {
TaskEventDispatcher taskEventDispatcher = new
TaskEventDispatcher();
final NetworkEnvironment networkEnvironment =
mock(NetworkEnvironment.class);
- when(networkEnvironment.createKvStateTaskRegistry(eq(jobId),
eq(jobVertexId))).thenReturn(mock(TaskKvStateRegistry.class));
when(networkEnvironment.getTaskEventDispatcher()).thenReturn(taskEventDispatcher);
final TaskExecutorLocalStateStoresManager
localStateStoresManager = createTaskExecutorLocalStateStoresManager();
+ final KvStateService kvStateService = new KvStateService(new
KvStateRegistry(), null, null);
Review comment:
this is the default anyway and we should be able to omit it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
