carp84 opened a new pull request #8076: [FLINK-12064] [core, State Backends] RocksDBKeyedStateBackend uses incorrect key serializer if reconfigure happens during restore URL: https://github.com/apache/flink/pull/8076 ## What is the purpose of the change This PR fixes the issue of using incorrect key serializer if reconfigured during restore in `RocksDBKeyedStateBackendBuilder`, which is a regression caused by FLINK-10043. We also reenforce the UT cases to cover the issue scenario. ## Brief change log Remove `keySerializer` from `AbstractKeyedStateBackendBuilder` and use `keySerializerProvider.currentSchemaSerializer()` instead in `RocksDBKeyedStateBackendBuilder`. For the test case part, perform an additional snapshot after state migration. ## Verifying this change This change added tests and can be verified as follows: * Reenforced `StateBackendMigrationTestBase`, adding an additional snapshot after state migration to verify the snapshot part. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (**yes**) * This change assures to use correct serializer in snapshot - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes**) * This change prevents possible corruption of snapshot data - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
