sunjincheng121 commented on issue #8057: [FLINK-12028][table] Add 
`addColumns`,`renameColumns`, `dropColumns` …
URL: https://github.com/apache/flink/pull/8057#issuecomment-478434229
 
 
   Hi, @dawidwys thanks for your valuable comments.  I have updated the PR with 
the following changes:
   
    - remove all batch test case
    - AddColumns(replaceIfExist, ..) -> AddOrReplaceColumns(...)
    - reduce ITcase in one method
    - Some doc improvement.
   
   Thanks again for your review and offline call. I appreciate if you can have 
a look at this PR again, and welcome any feedback! 
   
   Best,
   Jincheng

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to