KurtYoung commented on a change in pull request #8092: [FLINK-12076]
[table-planner-blink] Add support for generating optimized logical plan for
simple group aggregate on batch
URL: https://github.com/apache/flink/pull/8092#discussion_r271111545
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/FlinkRelOptUtil.scala
##########
@@ -110,6 +112,59 @@ object FlinkRelOptUtil {
aggCalls.exists(call => call.isDistinct && !call.isApproximate)
}
+ /**
+ * Check whether AUXILIARY_GROUP aggCalls is in the front of the given
agg's aggCallList,
+ * and whether aggCallList contain AUXILIARY_GROUP when the given agg's
groupSet is empty
+ * or the indicator is true.
+ * Returns AUXILIARY_GROUP aggCalls' args and other aggCalls.
+ *
+ * @param agg aggregate
+ * @return returns AUXILIARY_GROUP aggCalls' args and other aggCalls
+ */
+ def checkAndSplitAggCalls(agg: Aggregate): (Array[Int], Seq[AggregateCall])
= {
Review comment:
put this into `AggregateUtil`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
