azagrebin commented on a change in pull request #8048: [FLINK-12009] Fix wrong
check message about heartbeat interval for HeartbeatServices
URL: https://github.com/apache/flink/pull/8048#discussion_r271199140
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatServices.java
##########
@@ -40,7 +40,7 @@
public HeartbeatServices(long heartbeatInterval, long heartbeatTimeout)
{
Preconditions.checkArgument(0L < heartbeatInterval, "The
heartbeat interval must be larger than 0.");
- Preconditions.checkArgument(heartbeatInterval <=
heartbeatTimeout, "The heartbeat timeout should be larger or equal than the
heartbeat timeout.");
+ Preconditions.checkArgument(heartbeatInterval <=
heartbeatTimeout, "The heartbeat interval should be larger or equal than the
heartbeat timeout.");
Review comment:
From the actual comparison, it looks like the second `timeout` should be
changed to `interval` at the end of message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
