hequn8128 commented on a change in pull request #8062:  [FLINK-11884][table] 
Implement expression resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r272863163
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/ApiExpressionUtils.java
 ##########
 @@ -78,12 +83,12 @@ public static SymbolExpression symbol(TableSymbol symbol) {
                return new SymbolExpression(symbol);
        }
 
-       public static UnresolvedFieldReferenceExpression 
unresolvedFieldRef(String name) {
-               return new UnresolvedFieldReferenceExpression(name);
+       public static UnresolvedReferenceExpression unresolvedFieldRef(String 
name) {
 
 Review comment:
   Maybe we can change the method name from `unresolvedFieldRef` to 
`unresolvedRef`? We can use this method to create references to a field, local 
ref or table.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to