twalthr commented on a change in pull request #8062: [FLINK-11884][table]
Implement expression resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r272964598
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/ApiExpressionUtils.java
##########
@@ -78,12 +83,12 @@ public static SymbolExpression symbol(TableSymbol symbol) {
return new SymbolExpression(symbol);
}
- public static UnresolvedFieldReferenceExpression
unresolvedFieldRef(String name) {
- return new UnresolvedFieldReferenceExpression(name);
+ public static UnresolvedReferenceExpression unresolvedFieldRef(String
name) {
+ return new UnresolvedReferenceExpression(name);
}
public static TableReferenceExpression tableRef(String name, Table
table) {
Review comment:
True, registering the table under the hood is not perfect design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services