zhijiangW commented on issue #7835: [FLINK-11750][network] Replace IntermediateResultPartitionID with ResultPartitionID in ResultPartitionDeploymentDescriptor URL: https://github.com/apache/flink/pull/7835#issuecomment-480765630 Thanks for reviews and above suggestions @azagrebin . Your concern is reasonable, and I think this issue could further cover two aspects: 1. How to generate the `ResultPartitionID`? `ResultPartitionID ` is just a unique identifier for partition, even I think the `ResultPartitionID` might not cover `ExecutionAttepmtID` future. 2. Who to generate the `ResultPartitionID`? It could be created by `ShuffleMaster` or `ShuffleService`. In current implementation, `ResultPartitionID` is generated by `ShuffleMaster` in `InputChannelDeploymentDescriptor` on consumer side, but it is generated by `ShuffleService` on producer side. so it is not consistent ATM. The motivation for this PR is simplifying the interface method of `ShuffleService#createResultPartitionWriter` to not pass explicit parameter of `ExecutionAttemptID` which could be got from `ResultPartitionDeploymentDescriptor` instead. Then the creation of `ResultPartiitonID` is consistent on both sides.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
