pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots
which contain unconsumed result partitions (on top of #7186)
URL: https://github.com/apache/flink/pull/7938#discussion_r273038748
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
##########
@@ -120,15 +120,20 @@
/** True iff the component has been started. */
private boolean started;
+ /** Release task executor only when each produced result partition is
either consumed or failed.. */
+ private final boolean waitResultConsumedToRelease;
+
public SlotManager(
- ScheduledExecutor scheduledExecutor,
- Time taskManagerRequestTimeout,
- Time slotRequestTimeout,
- Time taskManagerTimeout) {
+ ScheduledExecutor scheduledExecutor,
+ Time taskManagerRequestTimeout,
+ Time slotRequestTimeout,
+ Time taskManagerTimeout,
Review comment:
optional nit: adding default constructor (or a builder) with
`TestingUtils.infiniteTime()` values for those three timeouts would also
simplify code by a little bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
