azagrebin commented on issue #7835: [FLINK-11750][network] Replace 
IntermediateResultPartitionID with ResultPartitionID in 
ResultPartitionDeploymentDescriptor
URL: https://github.com/apache/flink/pull/7835#issuecomment-480865772
 
 
   Eventually, it looks like `ResultPartiitonID` can stay a part of 
`ShuffleService` API. It could be generated inside 
`ShuffleMaster/ShuffleService`. From what I see, we would need it eventually 
only for `ResiultPartitionWriter.getPartitionId` to get `ResultPartiitonID` and 
use in `TaskEventDispatcher` to identify partition, otherwise it could be even 
completely an internal thing of `ShuffleService`. The `NetwrokEnviroment` also 
uses it internally to implicitly check that consumer requests correct partition 
from producer with correct `ExecutionAttemptID`. `ResultPartiitonID` can be 
always internally generated in `ShuffleMaster` from  
`PartitionShuffleDescriptor` and `ProducerShuffleDescriptor` to put it into 
`ShuffleDeploymentDescriptor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to