twalthr commented on a change in pull request #8062: [FLINK-11884][table]
Implement expression resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r273117051
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/logical/groupWindows.scala
##########
@@ -18,22 +18,25 @@
package org.apache.flink.table.plan.logical
+import java.util.Optional
+import java.util.{List => JList}
+
import org.apache.flink.table.api.{BatchTableEnvironment,
StreamTableEnvironment, TableEnvironment}
import
org.apache.flink.table.expressions.PlannerExpressionUtils.{isRowCountLiteral,
isRowtimeAttribute, isTimeAttribute, isTimeIntervalLiteral}
import org.apache.flink.table.expressions._
-import org.apache.flink.table.typeutils.TypeCheckUtils.{isTimePoint, isLong}
+import org.apache.flink.table.typeutils.TypeCheckUtils.{isLong, isTimePoint}
import org.apache.flink.table.validate.{ValidationFailure, ValidationResult,
ValidationSuccess}
//
------------------------------------------------------------------------------------------------
// Over windows
//
------------------------------------------------------------------------------------------------
case class LogicalOverWindow(
Review comment:
Make this file a POJO in `o.a.f.t.operations` in a separate commit? We need
some representation of windows as output of the API for the planner. Must not
necessarily containing expressions only. Or only resolved expressions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
