StefanRRichter commented on a change in pull request #8038: [FLINK-11953] 
Introduce Plugin/Loading system and integrate it with FileSystem
URL: https://github.com/apache/flink/pull/8038#discussion_r273360799
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/core/plugin/DirectoryBasedPluginFinder.java
 ##########
 @@ -68,39 +63,38 @@ public DirectoryBasedPluginFinder(Path pluginsRootDir) {
 
        @Override
        public Collection<PluginDescriptor> findPlugins() throws IOException {
+
+               if (!Files.isDirectory(pluginsRootDir)) {
+                       return Collections.emptyList();
 
 Review comment:
   Good question. No strong preference here so we could change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to