carp84 commented on a change in pull request #8122: [FLINK-12121] [State Backends] Use composition instead of inheritance for the InternalKeyContext logic in backend URL: https://github.com/apache/flink/pull/8122#discussion_r273402482
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/InternalKeyContextImpl.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.heap; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.runtime.state.KeyGroupRange; + +/** + * The default {@link InternalKeyContext} implementation. + * + * @param <K> Type of the key. + */ +public class InternalKeyContextImpl<K> implements InternalKeyContext<K> { + /** Range of key-groups for which this backend is responsible. */ + private final KeyGroupRange keyGroupRange; + /** The number of key-groups aka max parallelism. */ + private final int numberOfKeyGroups; + + /** The currently active key. */ + private K currentKey; + /** The key group of the currently active key. */ + private int currentKeyGroupIndex; + /** {@link TypeSerializer} for the state backend key type. */ + private TypeSerializer<K> currentKeySerializer; Review comment: After a second thought, key serializer is not required and could be final in both `StateTable` and backend. Have removed `keySerializer` field from `InternalKeyContextImpl` in the latest commit, please check and let me know whether it looks good. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
