azagrebin commented on a change in pull request #7938: [FLINK-10941] Keep slots
which contain unconsumed result partitions (on top of #7186)
URL: https://github.com/apache/flink/pull/7938#discussion_r273499960
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -203,4 +203,11 @@
* @return Future String with Fully qualified (RPC) address of Metric
Query Service on the TaskManager.
*/
CompletableFuture<SerializableOptional<String>>
requestMetricQueryServiceAddress(@RpcTimeout Time timeout);
+
+ /**
+ * Checks whether the task executor can be released. It cannot be
released if there're unconsumed result partitions.
+ *
+ * @return Future flag indicating whether the task executor can be
released.
+ */
+ CompletableFuture<Boolean> canBeReleased();
Review comment:
This a convention to tell RPC framework that the RPC communication can be
async, otherwise it is blocking. It does not necessary mean that the actual
implementation is async. I think the RPC communication does not have to be
synchronous in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
