zhijiangW opened a new pull request #8133: [FLINK-12146][network] Remove unregister task from NetworkEnvironment to simplify the interface of ShuffleService URL: https://github.com/apache/flink/pull/8133 ## What is the purpose of the change *`NetworkEnvironment#unregisterTask` is used for closing partition/gate and releasing partition from `ResultPartitionManager`. partition/gate close could be done in task which already maintains the arrays of them. Further we could release partition from `ResultPartitionManager` inside `ResultPartition` via introducing `ResultPartition#close(Throwable)`. To do so, the `NetworkEnvironment#unregisterTask` could be totally replaced to remove. The benefit is simplifying the method of `NetworkEnvironment` which would be regarded as default `ShuffleService` implementation.* ## Brief change log - *Remove `unregisterTask` from `NetworkEnvironment`* - *Introduce `close(Throwable)` in `ResultPartition` for releasing* - *Fix the related logic in task class* ## Verifying this change *This change is already covered by existing tests*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
