tzulitai commented on issue #7990: [FLINK-5018] Make source idle timeout user 
configurable
URL: https://github.com/apache/flink/pull/7990#issuecomment-481552760
 
 
   I've discussed this a bit with @aljoscha offline, and we still don't feel 
comfortable with enabling this yet.
   It's still something quite dangerous to enable generally at the moment, due 
to the fact with how different sources / connectors can have very different 
semantics for idleness.
   
   As we've also discussed offline @yanghua, if you agree that it is doable to 
use `SourceContext.markAsTemporarilyIdle` in your connectors, IMO that would be 
the safer way to go for now.
   
   We should nevertheless bring up this discussion in the FLIP-27 discussion, 
to make sure we're doing it right with the new source interface.
   
   If you agree, @yanghua, can you close this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to