zhijiangW opened a new pull request #8136: [FLINK-12154][network] Remove legacy fields for SingleInputGate URL: https://github.com/apache/flink/pull/8136 ## What is the purpose of the change *This work is a preparation for FLINK-11726.* *In `SingleInputGate#create`, we could remove unused parameter `ExecutionAttemptID`. And for the constructor of `SingleInputGate`, we could remove unused parameter `TaskIOMetricGroup`. Then we introduce `createSingleInputGate` for reusing the process of creating `SingleInputGate` in related tests.* ## Brief change log - *Remove `ExecutionAttemptID` parameter from `SingleInputGate#create`* - *Remove `TaskIOMetricGroup` from constructor of `SingleInputGate`* - *Introduce `createSingleInputGate` for tests reuse* ## Verifying this change *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
