tillrohrmann commented on a change in pull request #8116: [FLINK-11920][scala]
Reuse java classpath
URL: https://github.com/apache/flink/pull/8116#discussion_r273992844
##########
File path:
flink-scala/src/test/scala/org/apache/flink/api/scala/typeutils/EnumValueSerializerUpgradeTest.scala
##########
@@ -192,16 +192,7 @@ object EnumValueSerializerUpgradeTest {
val settings = new GenericRunnerSettings(out.println _)
- val classLoader = Thread.currentThread().getContextClassLoader
-
- val urls = classLoader match {
- case urlClassLoader: URLClassLoader =>
- urlClassLoader.getURLs
- case x => throw new IllegalStateException(s"Not possible to extract URLs
" +
- s"from class loader $x.")
- }
-
- settings.classpath.value =
urls.map(_.toString).mkString(java.io.File.pathSeparator)
+ settings.usejavacp.value = true
Review comment:
Maybe add a comment why we do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
