tillrohrmann commented on a change in pull request #8002:
[FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters
Suppliers
URL: https://github.com/apache/flink/pull/8002#discussion_r274057620
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -113,19 +114,12 @@ public MetricRegistryImpl(MetricRegistryConfiguration
config) {
// by default, don't report anything
LOG.info("No metrics reporter configured, no metrics
will be exposed/reported.");
} else {
- // we have some reporters so
- for (Tuple2<String, Configuration>
reporterConfiguration: reporterConfigurations) {
- String namedReporter = reporterConfiguration.f0;
- Configuration reporterConfig =
reporterConfiguration.f1;
-
- final String className =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX, null);
- if (className == null) {
- LOG.error("No reporter class set for
reporter " + namedReporter + ". Metrics might not be exposed/reported.");
- continue;
- }
+ for (ReporterSetup reporterSetup :
reporterConfigurations) {
+ final String namedReporter =
reporterSetup.getName();
+ final MetricConfig metricConfig =
reporterSetup.getConfiguration();
try {
- String configuredPeriod =
reporterConfig.getString(ConfigConstants.METRICS_REPORTER_INTERVAL_SUFFIX,
null);
+ String configuredPeriod =
metricConfig.getString(ConfigConstants.METRICS_REPORTER_INTERVAL_SUFFIX, null);
Review comment:
I think in general it is better to offer a restricted API because it usually
simplifies things. Here we have to provide the correct key in order to find the
right value. From a user's perspective who does not know the details of how
things are stored in `MetricConfig` it would be easier to simply call
`MetricConfig#getReporterInterval`. It would even be easier to call
`ScheduledMetricReporter#getReportertInterval` to relate this discussion to my
other point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
