zjffdu commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r274235386
########## File path: flink-core/src/main/java/org/apache/flink/core/plugin/PluginUtils.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.plugin; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.io.IOException; +import java.nio.file.Path; +import java.util.Collection; +import java.util.Collections; + +/** + * Utility functions for the plugin mechanism. + */ +public final class PluginUtils { Review comment: I also agree with @pnowojski to merge it into `PluginManager`. From a point viewer of plugin user, I would expect there's one only entry point to use plugin. So basically, I suppose it involves following 2 steps: 1. init PluginManager 2. create Plugin via PluginManager > some code could be interested in having multiple plugin manager or explicitly creating and passing in plugin managers. I am sure why user would do that. Only one scenario I can imagine is that user want to create a customized PluginManager explicitly for unit test. And I think the only thing to customize PluginManager is its plugin root folder, this could be set by a lot approaches like java property or system environment, so I think PluginManger itself could do that, we don't need PluginUtil for this. Maybe my understanding is wrong, just my 2 cents. 😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
