[ 
https://issues.apache.org/jira/browse/FLINK-12130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815395#comment-16815395
 ] 

Aljoscha Krettek commented on FLINK-12130:
------------------------------------------

[~victor-wong] Yes, please do that. One thing I would like to see changed, 
tough, is make {{applyCommandLineOptionsToConfiguration(CommandLine 
commandLine)}} a method of interface {{CustomCommandLine}} and change it to 
{{applyCommandLineOptionsToConfiguration(Configuration configuration, 
CommandLine commandLine)}}. That way you don't have to cast and it is more 
future proof, if the type of the Yarn command line ever changes.

> Apply command line options to configuration before installing security modules
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-12130
>                 URL: https://issues.apache.org/jira/browse/FLINK-12130
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command Line Client
>            Reporter: Victor Wong
>            Priority: Major
>
> Currently if the user configures Kerberos credentials through command line, 
> it won't work.
> {code:java}
> // flink run -m yarn-cluster -yD 
> security.kerberos.login.keytab=/path/to/keytab -yD 
> security.kerberos.login.principal=xxx /path/to/test.jar
> {code}
> Above command would cause security failure if you do not have a ticket cache 
> w/ kinit.
> Maybe we could call 
> _org.apache.flink.client.cli.AbstractCustomCommandLine#applyCommandLineOptionsToConfiguration_
>   before _SecurityUtils.install(new 
> SecurityConfiguration(cli.configuration));_
> Here is a demo patch: 
> [https://github.com/jiasheng55/flink/commit/ef6880dba8a1f36849f5d1bb308405c421b29986]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to