sunjincheng121 commented on a change in pull request #8087: 
[FLINK-12029][table] Add column operations for TableApi
URL: https://github.com/apache/flink/pull/8087#discussion_r274732538
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -5800,3 +5800,284 @@ For Table API, please use `_` for spaces (e.g., 
`DAY_TO_HOUR`).
 |                          | `SQL_TSI_SECOND ` _(SQL-only)_ |
 
 {% top %}
+
+Column Operations
 
 Review comment:
   I am also hesitating, because all of our functions can also be called 
expression, such as `=`, `<`, `>` These are Expressions, but our documentation 
is still called Comparison Functions, so I feel Expression is macro, and the 
functions are relatively specific. furthermore, we have defined it in 
`BuiltInFunctionDefinitions` What's your opinion? @hequn8128 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to