StefanRRichter commented on a change in pull request #8124: [FLINK-11877]
Implement the runtime handling of the InputSelectable interface
URL: https://github.com/apache/flink/pull/8124#discussion_r274775151
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
##########
@@ -197,22 +217,23 @@ public void requestPartitions() throws IOException,
InterruptedException {
return Optional.of(bufferOrEvent);
}
- @Override
- public Optional<BufferOrEvent> pollNextBufferOrEvent() throws
UnsupportedOperationException {
- throw new UnsupportedOperationException();
- }
-
- private InputGateWithData waitAndGetNextInputGate() throws IOException,
InterruptedException {
+ private InputGateWithData waitAndGetNextInputGate(boolean blocking)
throws IOException, InterruptedException {
Review comment:
Hm, if you can measure a performance penalty, I would probably not use it
but you could at least add a `@Nullable` for the return value instead. However,
if it is measurable, I wonder if there is not also impact from all the
`Optional` use in the surrounding code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
