dawidwys commented on a change in pull request #8007: [FLINK-11474][table] Add ReadableCatalog, ReadableWritableCatalog, and other … URL: https://github.com/apache/flink/pull/8007#discussion_r274801032
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDatabase.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog; + +import java.util.Map; + +/** + * Represents a database object in a catalog. + */ +public interface CatalogDatabase { Review comment: Do we know of any catalogs that would need that concept? I don't know I don't see any benefits in having those classes right now. Those properties you mentioned are system properties, which should be auto generated, are we going to do that for all catalogs? I really feel that we do not have any use cases for those classes. Could we do the same as with "moving tables between databases" and introduce it once we know what do we need them for? It's always easier to introduce new API than remove old one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
