wuchong commented on a change in pull request #8109:
[FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to
StreamTransformation
URL: https://github.com/apache/flink/pull/8109#discussion_r274953377
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecExchange.scala
##########
@@ -32,7 +44,10 @@ class StreamExecExchange(
relNode: RelNode,
relDistribution: RelDistribution)
extends CommonPhysicalExchange(cluster, traitSet, relNode, relDistribution)
- with StreamPhysicalRel {
+ with StreamPhysicalRel
+ with StreamExecNode[BaseRow] {
+
+ private val DEFAULT_MAX_PARALLELISM = 1 << 7
Review comment:
+1 . I'm in favor of the later one which is also used in
[`KeyedStream.java#134`
](https://github.com/apache/flink/blob/ddba1b69f43cbb885e178dfaafa120f1fe196a13/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java#L134)
and has a clear javadoc description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
