hequn8128 opened a new pull request #8162: [FLINK-12174][table] Introduce FlinkAggregateExtractProjectRule and remove extractFieldReferences URL: https://github.com/apache/flink/pull/8162 ## What is the purpose of the change This pull request adds FlinkAggregateExtractProjectRule for flink. This rule extracts a project from an aggregate. It is also helpful for removing the `extractFieldReferences` method which makes the API processing logic more clear. One thing to notice is Calcite has already contained an AggregateExtractProjectRule. However, this rule takes no consideration for `LogicalWindowAggregate`. Most of the logic in this rule is same with `AggregateExtractProjectRule`. The difference is this rule has also taken the `LogicalWindowAggregate` into consideration. I didn't add the `FlinkAggregateExtractProjectRule` into logical ruleset directly, as using Hep Planner to do pre-optimization can greatly reduce time in the volcano phase. ## Brief change log - Add FlinkAggregateExtractProjectRule. - Remove `extractFieldReferences` method. - Adjust tests. ## Verifying this change This change is already covered by existing tests, such as GroupWindowTest and AggregateTest for batch and streaming. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
