zhijiangW commented on a change in pull request #8133: [FLINK-12146][network]
Remove unregister task from NetworkEnvironment to simplify the interface of
ShuffleService
URL: https://github.com/apache/flink/pull/8133#discussion_r275201785
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -326,6 +326,23 @@ public void release(Throwable cause) {
@Override
public void close() {
+ close(null);
+ }
+
+ /**
+ * There are two scenarios to close the result partition.
+ *
+ * <p>For FINISHED task, we only destroy buffer pool to free available
segments.
+ *
+ * <p>For FAILED or CANCELING task, we should also release the result
partition.
+ *
+ * @param throwable which indicates FAILED/CANCELING task if not null
+ */
+ public void close(Throwable throwable) {
Review comment:
That is a good idea. The semantic is more clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
