dawidwys commented on a change in pull request #8050: [FLINK-11067][table]
Convert TableEnvironments to interfaces
URL: https://github.com/apache/flink/pull/8050#discussion_r275221999
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvImpl.scala
##########
@@ -65,16 +58,20 @@ import
org.apache.flink.table.typeutils.TimeIndicatorTypeInfo
import org.apache.flink.table.validate.FunctionCatalog
import org.apache.flink.types.Row
-import _root_.scala.annotation.varargs
import _root_.scala.collection.JavaConverters._
import _root_.scala.collection.mutable
/**
- * The abstract base class for batch and stream TableEnvironments.
+ * The abstract base class for the implementation of batch and stream
TableEnvironments.
*
* @param config The configuration of the TableEnvironment
*/
-abstract class TableEnvironment(val config: TableConfig) {
+abstract class TableEnvImpl(val config: TableConfig) extends TableEnvironment {
+
+ // Init PlannerConfig with the DefaultPlannerConfig
+ if (config.getPlannerConfig == null) {
+ config.setPlannerConfig(DefaultPlannerConfig.createBuilder().build())
Review comment:
Let's not set anything here. `TableEnvImpl` is meant to be moved to api
module. `DefaultPlannerConfig` won't be in the scope anymore.
This is where `Optional` comes in handy. On the planner side we will just
do:
```
plannerConfig.unwrap(DefaultPlannerConfig.class).orElse(DefaultPlannerConfig.DEFAULT)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
