GJL commented on a change in pull request #7978: [FLINK-11910] [Yarn] add
customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r275262694
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -468,6 +470,8 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
flinkConfiguration.setString(dynProperty.getKey(),
dynProperty.getValue());
}
+ this.applicationType =
dynProperties.getOrDefault("application-type", "");
Review comment:
Correct me if I am wrong but it seems that we use the dynamic properties
only for adding/overriding properties in the flink configuration (i.e.,
`flink-conf.yaml`). Therefore, I think setting the `applicationType` should be
handled via a regular command line option (similar to `customName`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
