twalthr commented on a change in pull request #8062: [FLINK-11884][table]
Implement expression resolution on top of new Expressions
URL: https://github.com/apache/flink/pull/8062#discussion_r275289448
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/table/TemporalTableJoinTest.scala
##########
@@ -156,12 +156,12 @@ class TemporalTableJoinTest extends TableTestBase {
inputRates: TemporalTableFunction,
proctime: Boolean = false): Unit = {
val rates = inputRates.asInstanceOf[TemporalTableFunctionImpl]
- assertTrue(rates.getPrimaryKey.isInstanceOf[ResolvedFieldReference])
- assertEquals("currency",
rates.getPrimaryKey.asInstanceOf[ResolvedFieldReference].name)
- assertTrue(rates.getTimeAttribute.isInstanceOf[ResolvedFieldReference])
+ assertTrue(rates.getPrimaryKey.isInstanceOf[FieldReferenceExpression])
Review comment:
nit: use object equality instead of casting. Just construct the expression
that you except.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
