twalthr commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r275327749
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/tableImpl.scala ########## @@ -55,8 +56,7 @@ class TableImpl( var tableName: String = _ - def getRelNode: RelNode = operationTree.asInstanceOf[LogicalNode] - .toRelNode(tableEnv.getRelBuilder) + def getRelNode: RelNode = tableEnv.getRelBuilder.flinkTableOperation(operationTree).build() Review comment: rename to `tableOperation`. I would avoid the name of the project in identifiers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
