azagrebin commented on a change in pull request #8133: [FLINK-12146][network]
Remove unregister task from NetworkEnvironment to simplify the interface of
ShuffleService
URL: https://github.com/apache/flink/pull/8133#discussion_r275360039
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -879,6 +875,62 @@ else if (transitionState(current, ExecutionState.FAILED,
t)) {
}
}
+ private void releaseNetworkResources() {
+ LOG.debug("Release task {} network resources (state: {}).",
taskNameWithSubtask, getExecutionState());
+
+ for (ResultPartition partition : producedPartitions) {
+
taskEventDispatcher.unregisterPartition(partition.getPartitionId());
+ }
+
+ closeNetworkResources(producedPartitions, inputGates,
isCanceledOrFailed(), getFailureCause(), taskNameWithSubtask);
+ }
+
+ private static void closeNetworkResources(
Review comment:
This seems to be used only in one place, I would remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
