twalthr commented on a change in pull request #8162: [FLINK-12174][table]
Introduce FlinkAggregateExtractProjectRule and remove extractFieldReferences
URL: https://github.com/apache/flink/pull/8162#discussion_r275765075
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/batch/sql/SingleRowJoinTest.scala
##########
@@ -187,7 +187,7 @@ class SingleRowJoinTest extends TableTestBase {
unaryNode(
"DataSetCalc",
batchTableNode(1),
- term("select", "0 AS $f0")),
+ term("select", "")),
Review comment:
This looks wrong. Do we support empty rows? Could you verify this with an IT
case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
