klion26 commented on a change in pull request #8183: [FLINK-12210][Runtime]Fix
the bug of redundant removing of '\r'
URL: https://github.com/apache/flink/pull/8183#discussion_r275775877
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/AbstractPagedInputView.java
##########
@@ -398,9 +398,7 @@ public String readLine() throws IOException {
try {
int b;
while ((b = readUnsignedByte()) != '\n') {
- if (b != '\r') {
- bld.append((char) b);
- }
+ bld.append((char) b);
Review comment:
I don't think this can be changed, here we remove all the '\r' and line 412
just remove the last '\r'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
