tillrohrmann commented on a change in pull request #8144: [FLINK-12159]. Enable
YarnMiniCluster integration test under non-secure mode
URL: https://github.com/apache/flink/pull/8144#discussion_r275824896
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -877,6 +867,18 @@ public ApplicationReport startAppMaster(
Path remoteYarnSiteXmlPath = null;
boolean hasKrb5 = false;
if (System.getenv("IN_TESTS") != null) {
+ File f = new File(System.getenv("YARN_CONF_DIR"),
Utils.YARN_SITE_FILE_NAME);
Review comment:
Are we sure that this file always exists? What happens if this file does not
exist? I think it would be best if we keep the test code as close to the
production code as possible. In this case it would mean that we set the
environment of the Yarn container up in a way that we don't have to explicitly
ship the `yarn-site.xml` to it, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
