azagrebin commented on a change in pull request #8189: [FLINK-12195] [YARN] 
Incorrect resource time setting causes flink to fail to submit
URL: https://github.com/apache/flink/pull/8189#discussion_r275878797
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
 ##########
 @@ -161,14 +161,9 @@ public static void setupYarnClassPath(Configuration conf, 
Map<String, String> ap
 
                fs.copyFromLocalFile(false, true, localSrcPath, dst);
 
-               // Note: If we used registerLocalResource(FileSystem, Path) 
here, we would access the remote
 
 Review comment:
   This comment basically explains why we cannot just query the timestamp from 
remote filesystem, like this:
   `fs.getFileStatus(dst)`. You are also trying to basically revert the fix 
introduced in [FLINK-8801](https://issues.apache.org/jira/browse/FLINK-8801).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to