zhijiangW commented on issue #8191: [FLINK-12213][network] Pass TaskManagerMetricGroup into constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8191#issuecomment-483932037 Considering my above comments, I added the `TaskManagerMetricGroup#close` during `TaskManagerServices#shutdown` to keep consistent with other components in `TaskManagerServices`. Regarding the usages of `NetworkEnvironment#getNetworkBufferPool` in current two tests, one can be fixed during creation of partition/gate inside `NetworkEnvironment` in other PR, and another can also be avoided by introducing `NetworkEnvironmentBuilder` to give `NetworkBufferPool` explicitly outside which would be adjusted in a separate PR if necessary. @azagrebin
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
