liyafan82 commented on issue #8194: [FLINK-12216][Runtime]Respect the number of bytes from input paramete… URL: https://github.com/apache/flink/pull/8194#issuecomment-483981625 > Looks like a legitimate bug, thanks for fixing it. > > One comment on the test assumptions. > This also needs another test for the "get" method. Thanks for the good point. The test case for the "get" method is a little tricky. If we use a read only byte buffer, it is neither off heap, nor has an array, so it will go to the branch concerned. However, the method will throw a ReadOnlyBufferException when inserting data into the byte buffer. So this patch is not really evaluated. Anyway, this test can be added, if you think it is reasonable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
