hequn8128 commented on issue #8050: [FLINK-11067][table] Convert TableEnvironments to interfaces URL: https://github.com/apache/flink/pull/8050#issuecomment-484150446 @dawidwys Hi, thank you very much for the review. I have addressed all your comments, except for the one about changing the interface to TableSource/Sink for TableFactories. I also agree with you and it would be nice if we can remove the reflections. However, the main concern is the compatible problem. The interface is widely used by users. Maybe we can have some opinions from @twalthr . What do you think? Thank you again for the nice review. Best, Hequn
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
