[
https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14732531#comment-14732531
]
ASF GitHub Bot commented on FLINK-2017:
---------------------------------------
GitHub user mliesenberg opened a pull request:
https://github.com/apache/flink/pull/1097
[FLINK-2017] Add predefined required parameters to ParameterTool
- adds Option class to represent required parameter
- adds RequiredParameter class to interact with ParameterTool to check
and/or validate parameters
- adds corresponding unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mliesenberg/flink feature/FLINK-2017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1097
----
commit 81c2ad7f792acb7ed4e01057fc5e807f752f902e
Author: Martin Liesenberg <[email protected]>
Date: 2015-09-06T20:18:13Z
[FLINK-2017] Add predefined required parameters to ParameterTool
- adds Option class to represent required parameter
- adds RequiredParameter class to interact with ParameterTool to check
and/or validate parameters
- adds corresponding unit tests
----
> Add predefined required parameters to ParameterTool
> ---------------------------------------------------
>
> Key: FLINK-2017
> URL: https://issues.apache.org/jira/browse/FLINK-2017
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 0.9
> Reporter: Robert Metzger
> Labels: starter
>
> In FLINK-1525 we've added the {{ParameterTool}}.
> During the PR review, there was a request for required parameters.
> This issue is about implementing a facility to define required parameters.
> The tool should also be able to print a help menu with a list of all
> parameters.
> This test case shows my initial ideas how to design the API
> {code}
> @Test
> public void requiredParameters() {
> RequiredParameters required = new RequiredParameters();
> Option input = required.add("input").alt("i").help("Path to
> input file or directory"); // parameter with long and short variant
> required.add("output"); // parameter only with long variant
> Option parallelism =
> required.add("parallelism").alt("p").type(Integer.class); // parameter with
> type
> Option spOption =
> required.add("sourceParallelism").alt("sp").defaultValue(12).help("Number
> specifying the number of parallel data source instances"); // parameter with
> default value, specifying the type.
> Option executionType =
> required.add("executionType").alt("et").defaultValue("pipelined").choices("pipelined",
> "batch");
> ParameterUtil parameter = ParameterUtil.fromArgs(new
> String[]{"-i", "someinput", "--output", "someout", "-p", "15"});
> required.check(parameter);
> required.printHelp();
> required.checkAndPopulate(parameter);
> String inputString = input.get();
> int par = parallelism.getInteger();
> String output = parameter.get("output");
> int sourcePar = parameter.getInteger(spOption.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
