JingsongLi edited a comment on issue #8184: [FLINK-12211][table-planner-blink] Add more it cases to blink batch URL: https://github.com/apache/flink/pull/8184#issuecomment-484346031 > > #8165 make CalcITCase.testTimestampCompareWithDateString fail. Some bug in #8165 . > > The bug is in codegen, not in #8165. codegen needs to handle `Calc(select=[j], where=[<(j, CAST(_UTF-16LE'2017-11-11'))])` correctly. In blink, some advanced rules will convert `CAST(_UTF-16LE'2017-11-11'):TIMESTAMP(3) NOT NULL)` to a timestamp value directly, however those rules have not been ported to flink yet. Because our CodeGen not support varchar(yyyy-mm-dd) cast to timestamp(return null). But calcite support it. So if the plan use calcite method to reduce the cast expression, the case will pass. But if the plan did not reduce the cast, the case will fail. I add todo to the case, Let's support later.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
