zentol commented on a change in pull request #8191: [FLINK-12213][network] Pass
TaskManagerMetricGroup into constructor of NetworkEnvironment
URL: https://github.com/apache/flink/pull/8191#discussion_r276623978
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java
##########
@@ -93,30 +91,26 @@ public static JobManagerMetricGroup
instantiateJobManagerMetricGroup(
public static TaskManagerMetricGroup instantiateTaskManagerMetricGroup(
MetricRegistry metricRegistry,
- TaskManagerLocation taskManagerLocation,
- NetworkEnvironment network,
+ String hostName,
+ ResourceID resourceID,
Optional<Time> systemResourceProbeInterval) {
final TaskManagerMetricGroup taskManagerMetricGroup = new
TaskManagerMetricGroup(
metricRegistry,
- taskManagerLocation.getHostname(),
- taskManagerLocation.getResourceID().toString());
+ hostName,
+ resourceID.toString());
MetricGroup statusGroup =
taskManagerMetricGroup.addGroup(METRIC_GROUP_STATUS_NAME);
// Initialize the TM metrics
instantiateStatusMetrics(statusGroup);
- MetricGroup networkGroup = statusGroup
- .addGroup("Network");
- instantiateNetworkMetrics(networkGroup, network);
-
if (systemResourceProbeInterval.isPresent()) {
instantiateSystemMetrics(taskManagerMetricGroup,
systemResourceProbeInterval.get());
}
return taskManagerMetricGroup;
}
- public static void instantiateStatusMetrics(
+ private static void instantiateStatusMetrics(
Review comment:
unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
